fix(scripts): codegen cleanup #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
reviewed
May 19, 2022
Comment on lines
+69
to
+71
| jest.spyOn(common, 'run').mockImplementation(() => { | ||
| return Promise.resolve(mockedResolvedValue); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| jest.spyOn(common, 'run').mockImplementation(() => { | |
| return Promise.resolve(mockedResolvedValue); | |
| }); | |
| jest.spyOn(common, 'run').mockResolvedValue(mockedResolvedValue); |
There was a problem hiding this comment.
idk why I did not managed to make it work at first so went with the non sugar implem
There was a problem hiding this comment.
Ah yes it's because the mockedResolvedValue variable changes and need to be reevaluated everytime, while mockResolvedValue function only evaluate at the start.
millotp
approved these changes
May 19, 2022
This was referenced May 19, 2022
This was referenced May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
Follow up of #513
It seems that the
cleanupjob is ran onmain(https://github.com/algolia/api-clients-automation/runs/6507516796?check_suite_focus=true), so the comment ends up being wrong: #513 (comment)We now provide the current branch name directly from
HEAD_BRANCH, so we can fallback to it if we are on main🧪 Test
CI :D